Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort call feeds consistently when choosing active speaker #360

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Sort call feeds consistently when choosing active speaker #360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff9073
Sort call feeds consistently when choosing active speaker
dbkr May 30, 2022
771424c
Expand comment
dbkr Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/room/usePTT.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@ function getActiveSpeakerFeed(
): CallFeed | null {
const activeSpeakerFeeds = feeds.filter((f) => !f.isAudioMuted());

// make sure the feeds are in a deterministic order so every client picks
// the same one as the active speaker
const collator = new Intl.Collator("en", {
sensitivity: "variant",
usage: "sort",
ignorePunctuation: false,
});
activeSpeakerFeeds.sort((a: CallFeed, b: CallFeed): number =>
collator.compare(a.userId, b.userId)
);
robintown marked this conversation as resolved.
Show resolved Hide resolved

let activeSpeakerFeed = null;
let highestPowerLevel = null;
for (const feed of activeSpeakerFeeds) {
Expand Down