Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouseup/down behaviour of PTT button #311

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 4, 2022

Handle mouseup events anywhere so the button releases if you move
the cursor out of the button & release. Likewsie for window losing
focus.

Handle mouseup events anywhere so the button releases if you move
the cursor out of the button & release. Likewsie for window losing
focus.
@dbkr dbkr requested a review from robertlong May 4, 2022 15:54
Copy link
Contributor

@robertlong robertlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I think the document mouseup event handler makes sense

@dbkr dbkr merged commit a6eb52a into main May 6, 2022
@dbkr dbkr deleted the dbkr/fix_pt_button_behaviour branch December 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants