Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in SFU mode on hangup #830

Closed
dbkr opened this issue Jan 6, 2023 · 1 comment
Closed

NPE in SFU mode on hangup #830

dbkr opened this issue Jan 6, 2023 · 1 comment
Assignees
@SimonBrandner
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@dbkr
Copy link
Member

dbkr commented Jan 6, 2023

Steps to reproduce

  1. Enter call in SFU mode
  2. Not sure (other participant hangs up, maybe?)

Outcome

NPE on https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/webrtc/groupCall.ts#L1034 - Cannot read properties of null (reading 'userId') because invitee is the sfu, which is not in the room.

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No
@dbkr dbkr added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 6, 2023
SimonBrandner added a commit to matrix-org/matrix-js-sdk that referenced this issue Jan 6, 2023
@SimonBrandner
Make onCallHangup work with focus calls
378cf79 
Fixes element-hq/element-call#830

Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Copy link
Contributor

Fixed by matrix-org/matrix-js-sdk@378cf79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @SimonBrandner