Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTT - bad-network conditions currently break PTT semantics partly #331

Closed
Tracked by #301
fkwp opened this issue May 17, 2022 · 2 comments
Closed
Tracked by #301

PTT - bad-network conditions currently break PTT semantics partly #331

fkwp opened this issue May 17, 2022 · 2 comments
Assignees
@dbkr
Milestone
Push-to-Talk

Comments

@fkwp
Copy link
Contributor

fkwp commented May 17, 2022 •
edited
Loading

Under certain (bad network) circumstances the reliability of the WebRTC or the home-sever network connection might differ significantly which triggers unwanted behavior in the PTT logic.
@fkwp fkwp changed the title PTT - Investigate and tune bad network conditions PTT - bad-network conditions currently break PTT semantics partly May 18, 2022
@fkwp fkwp mentioned this issue May 18, 2022
Closed
8 tasks
@dbkr dbkr self-assigned this May 18, 2022
@fkwp fkwp added this to the Push-to-Talk milestone May 19, 2022
@fkwp
Copy link
Contributor Author

fkwp commented May 25, 2022

matrix-org/matrix-js-sdk#2401

This was referenced May 30, 2022
Merged
Merged
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue May 30, 2022
@dbkr
Mute disconnected peers in PTT mode
746d6ac 
When we lose ICE connection to peers, set the status of their feeds
to muted so to end their talking session.

For element-hq/element-call#331
@dbkr dbkr mentioned this issue May 30, 2022
Merged
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue May 31, 2022
@dbkr
Mute disconnected peers in PTT mode (#2421)
34ef7bc 
When we lose ICE connection to peers, set the status of their feeds
to muted so to end their talking session.

For element-hq/element-call#331
@dbkr
Copy link
Member

dbkr commented Jun 17, 2022

Going to close this now as we've done the planned work on it. If we find that we need more in practice, we can open another issue.

@dbkr dbkr closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
None yet
Projects
None yet
Milestone
Push-to-Talk
Development

No branches or pull requests
2 participants
@dbkr @fkwp