Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTT - Block from transmitting if another user is transmitting #298

Closed
fkwp opened this issue Apr 13, 2022 · 1 comment
Closed

PTT - Block from transmitting if another user is transmitting #298

fkwp opened this issue Apr 13, 2022 · 1 comment
Milestone
Push-to-Talk

Comments

@fkwp
Copy link
Contributor

fkwp commented Apr 13, 2022

  • As a user who presses the transmit button when anyone else is transmitting, or has pressed the button before me
  • I want to be blocked from transmitting
  • So that I do not speak over other users
@fkwp fkwp mentioned this issue Apr 14, 2022
Closed
8 tasks
@dbkr dbkr changed the title PTT - Block from transmitting is another user is transmitting PTT - Block from transmitting if another user is transmitting Apr 21, 2022
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 21, 2022
@dbkr
Don't allow user to unmute if another user is speaking
f5286a5 
Based on #2312
For element-hq/element-call#298
@dbkr dbkr mentioned this issue Apr 21, 2022
Merged
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 22, 2022
@dbkr
Don't allow user to unmute if another user is speaking (#2313)
cc60492 
* Add maximum trasmit time for PTT

on sender side by muting mic after the max transmit time has elapsed.

* Don't allow user to unmute if another user is speaking

Based on #2312
For element-hq/element-call#298
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue May 3, 2022
@dbkr
Support for PTT group call mode (#2338)
8d9cd0f 
* Add PTT call mode & mute by default in PTT calls (#2311)

No other parts of PTT calls implemented yet

* Make the tests pass again (#2316)

3280394
made call use a bunch of methods that weren't mocked in the tests.

* Add maximum trasmit time for PTT (#2312)

on sender side by muting mic after the max transmit time has elapsed.

* Don't allow user to unmute if another user is speaking  (#2313)

* Add maximum trasmit time for PTT

on sender side by muting mic after the max transmit time has elapsed.

* Don't allow user to unmute if another user is speaking

Based on #2312
For element-hq/element-call#298

* Fix createGroupCall arguments (#2325)

Comma instead of a colon...
@dbkr
Copy link
Member

dbkr commented May 5, 2022

Now done!

@dbkr dbkr closed this as completed May 5, 2022
@fkwp fkwp added this to the Push-to-Talk milestone Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Push-to-Talk
Development

No branches or pull requests
2 participants
@dbkr @fkwp