Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emoji verification for RTL languages #8237 #8522

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pt2121
Copy link
Contributor

@pt2121 pt2121 commented Jun 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

As mentioned in #8237, the emojis are in a wrong order in RTL.

Screenshots / GIFs

Screenshots on the left are from the web in English (RTL) and ones on the right are from LTR languages.

image

Tests

  1. Change phone language to Hebrew or RTL languages
  2. Go through the verification using emoji
  3. Compare the emojis

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 5, 11 and 12

Checklist

@jmartinesp jmartinesp added the Z-Community-PR Issue is solved by a community member's PR label Jun 12, 2023
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on.
Need to think a bit more on that one, because if you actually spell out loud the emojis you will get the correct order. If we fix the order, we would have to update the text to say in what order it should be read

@pt2121
Copy link
Contributor Author

pt2121 commented Jun 12, 2023

we would have to update the text to say in what order it should be read

Sorry, I am not sure I follow. Can you elaborate?
With this fix, the emojis would be read the same whether the user reads from RTL or LTR. Isn't that what we want?

@jmartinesp
Copy link
Member

we would have to update the text to say in what order it should be read

Sorry, I am not sure I follow. Can you elaborate? With this fix, the emojis would be read the same whether the user reads from RTL or LTR. Isn't that what we want?

The UI says 'ensure they appear in the same order', but wouldn't a RTL user read the emojis from right to left? In that case, the 'first' one in LTR would be the leftmost one and in RTL the rightmost one, right? I'm not a RTL user myself, so I'm not sure if that's the case.

@pt2121
Copy link
Contributor Author

pt2121 commented Jun 12, 2023

I see the point now. I'm wondering how we handle this on iOS and web.
I sort of assume the same user would casually see that emojis look the same regardless of what language is set but I could be really wrong here. 😅

This is an interesting UX question.

Edited: Just checked this in Persian on iOS, fwiw, with this change, the emoji would in the same order on iOS and Android.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants