Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch avatars without CORS #168

Merged
merged 1 commit into from
May 14, 2024
Merged

Fetch avatars without CORS #168

merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. Fetch avatars without CORS 

    By omitting the crossOrigin attribute, we change avatars to use a non-CORS request to fetch the image. This allows avatars to load even on null origins (fixing element-hq/element-web#26491), but also prevents us from inspecting the image data in JavaScript, for example by using it in a canvas. We weren't doing that of course, so switching to the locked-down non-CORS mode should have no consequences.
    @robintown
    robintown committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5f0b5bd View commit details
    Browse the repository at this point in the history