add: add postslug argument to comment request

eleijonmarck · Jun 28, 2022 · 452f6e2 · 452f6e2
1 parent 91dc77a
commit 452f6e2
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 31 deletions.
diff --git a/proto/blog/v1/query.proto b/proto/blog/v1/query.proto
@@ -23,7 +23,8 @@ message QueryAllPostsResponse {
 }
 
 message QueryAllCommentsRequest {
-  cosmos.base.query.v1beta1.PageRequest pagination = 1;
+  string postSlug = 1;
+  cosmos.base.query.v1beta1.PageRequest pagination = 2;
 }
 
 message QueryAllCommentsResponse {

diff --git a/x/blog/query.pb.go b/x/blog/query.pb.go
diff --git a/x/blog/requests.go b/x/blog/requests.go
@@ -37,15 +37,15 @@ func (m *MsgCreatePost) GetSigners() []sdk.AccAddress {
 }
 
 func (m *MsgCreateComment) ValidateBasic() error {
+	if m.PostSlug == "" {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "no post slug")
+	}
 	if m.Author == "" {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "no author")
 	}
 	if m.Body == "" {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "no body")
 	}
-	if m.PostSlug == "" {
-		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "no slug")
-	}
 
 	return nil
 }

diff --git a/x/blog/server/msg_server.go b/x/blog/server/msg_server.go
@@ -45,8 +45,8 @@ func (s serverImpl) CreateComment(goCtx context.Context, request *blog.MsgCreate
 	store := prefix.NewStore(ctx.KVStore(s.storeKey), blog.KeyPrefix(blog.CommentKey))
 
 	key := []byte(request.PostSlug)
-	if store.Has(key) {
-		return nil, sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "duplicate slug %s found", request.PostSlug)
+	if !store.Has(key) {
+		return nil, sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "post %s to comment on does not exist in state", request.PostSlug)
 	}
 
 	comment := blog.Comment{