feat: add electron/utility module for utility process #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2023
Includes changes from electron/docs-parser#95 to add utility process.
devm33
force-pushed
the
devm33/utility
branch
from
0781d2d to
1983724
Compare
|
@MarshallOfSound or @dsanders11 would you be able to review this as a follow up to electron/docs-parser#95 Thanks! |
dsanders11
approved these changes
Oct 13, 2023
|
Thanks for reviewing @dsanders11! Would you be able to merge and deploy this change so I can use it in electron/electron#40017 |
|
🎉 This PR is included in version 8.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
devm33
added a commit
to devm33/electron
that referenced
this pull request
Oct 17, 2023
To include changes to add utility process types from: electron/docs-parser#95 electron/typescript-definitions#246
devm33
added a commit
to devm33/electron
that referenced
this pull request
Oct 18, 2023
Upgrades docs-parser and typescript-definitions to add new 'electron/utility' namespace added in: electron/docs-parser#95 electron/typescript-definitions#246
Merged
3 tasks
devm33
added a commit
to devm33/typescript-definitions
that referenced
this pull request
Oct 19, 2023
Added in electron#246, the Utility namespace currently has no concrete values in it on electron/electron@main. This change ensures Electron.Utility is available as a property even when the namespace has no values.
devm33
added a commit
to devm33/typescript-definitions
that referenced
this pull request
Oct 25, 2023
Added in electron#246, the Utility namespace currently has no concrete values in it on electron/electron@main. This change ensures Electron.Utility is available as a property even when the namespace has no values.
dsanders11
pushed a commit
that referenced
this pull request
Oct 25, 2023
* fix: ensure Electron.Utility property exists Added in #246, the Utility namespace currently has no concrete values in it on electron/electron@main. This change ensures Electron.Utility is available as a property even when the namespace has no values. * fix: only set Utility property if namespace empty If the Utility namespace has concrete values and the const Utility property is set it causes `error TS2300: Duplicate identifier 'Utility'.` This tracks whether any values are added to the Utility namespace and only sets the property workaround if there are none.
devm33
added a commit
to devm33/electron
that referenced
this pull request
Oct 26, 2023
Upgrades docs-parser and typescript-definitions to add new 'electron/utility' namespace added in: - electron/docs-parser#95 - electron/typescript-definitions#246 - electron/typescript-definitions#247
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 31, 2023
…ons (#40264) * feat: add utility process typescript namespace Upgrades docs-parser and typescript-definitions to add new 'electron/utility' namespace added in: - electron/docs-parser#95 - electron/typescript-definitions#246 - electron/typescript-definitions#247 * build: update yarn.lock --------- Co-authored-by: David Sanders <[email protected]>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…ons (electron#40264) * feat: add utility process typescript namespace Upgrades docs-parser and typescript-definitions to add new 'electron/utility' namespace added in: - electron/docs-parser#95 - electron/typescript-definitions#246 - electron/typescript-definitions#247 * build: update yarn.lock --------- Co-authored-by: David Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
'electron/utility'module for modules available to the utility process.This PR depends on electron/docs-parser#95 in order to add the
ProcessBlock.utilityproperty.Opting to make the change in a minimal way to not interfere with the main+renderer=common logic and just add the additional
Utilitywith just the minimal set of exports available to the utility process.See electron/electron#40017 for an example of adding new API to the utility process that will need this change.