Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update @electron/docs-parser and @electron/typescript-definitions #40264

Merged
merged 2 commits into from
Oct 31, 2023
Merged

build: update @electron/docs-parser and @electron/typescript-definitions #40264

merged 2 commits into from
Oct 31, 2023

Conversation

devm33
Copy link
Contributor

@devm33 devm33 commented Oct 18, 2023 •
edited
Loading

Description of Change

Upgrades docs-parser and typescript-definitions to add new 'electron/utility' namespace added in:

Also removes obsolete remote interface: electron/typescript-definitions#249

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2023
@devm33 devm33 mentioned this pull request Oct 18, 2023
Merged
11 tasks
jkleinsc
jkleinsc requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to security restrictions, yarn.lock changes are restricted to maintainers only.

Additionally, it appears that this change does not pass lint: https://app.circleci.com/pipelines/github/electron/electron/75605/workflows/dcf582a9-b884-415b-8c2f-56bf047d13d0/jobs/1622825

@devm33
Copy link
Contributor Author

devm33 commented Oct 19, 2023

Thanks for taking a look!

Due to security restrictions, yarn.lock changes are restricted to maintainers only.

Should the PR only include package.json changes or does a maintainer need to do this PR?

Additionally, it appears that this change does not pass lint: https://app.circleci.com/pipelines/github/electron/electron/75605/workflows/dcf582a9-b884-415b-8c2f-56bf047d13d0/jobs/1622825

Sorry yes working on fixing! #40017 (comment)

@devm33 devm33 mentioned this pull request Oct 19, 2023
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2023
@devm33
feat: add utility process typescript namespace
8065393 
Upgrades docs-parser and typescript-definitions to add new
'electron/utility' namespace added in:
- electron/docs-parser#95
- electron/typescript-definitions#246
- electron/typescript-definitions#247
@devm33 devm33 force-pushed the devm33/utility_namespace branch from 4e61e1d to 8065393 Compare October 26, 2023 02:40
@devm33
Copy link
Contributor Author

devm33 commented Oct 26, 2023

@jkleinsc I've updated here with the fix for the typescript-definitions change electron/typescript-definitions#247 and dropped the yarn.lock changes. Unfortunately, that does mean lint is now failing due to the package.json and yarn.lock being out of sync.

error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. https://app.circleci.com/pipelines/github/electron/electron/75794/workflows/7803b286-c927-4c3f-b3a2-48cfa187f9d5/jobs/1626190

@devm33 devm33 requested a review from jkleinsc October 26, 2023 19:00
@dsanders11 dsanders11 added semver/minor backwards-compatible functionality no-backport labels Oct 27, 2023
@dsanders11 dsanders11 added semver/patch backwards-compatible bug fixes and removed semver/minor backwards-compatible functionality labels Oct 27, 2023
@dsanders11
Copy link
Member

I've added the yarn.lock changes myself and pushed them, but it should be noted this lands multiple changes from these packages (including dropping the remote interface stuff), so I think the title should probably be more generic so it better matches all of the functional changes, e.g. "build: update @electron/docs-parser and @electron/typescript-definitions".

FYI @devm33, I think you may be using an older version of yarn which is causing your yarn.lock changes to be bigger than necessary. Your original yarn.lock changes were in the thousands of lines, while mine is less than 10.

@devm33 devm33 changed the title feat: add utility process typescript namespace build: update @electron/docs-parser and @electron/typescript-definitions Oct 27, 2023
@devm33
Copy link
Contributor Author

devm33 commented Oct 27, 2023

Thanks @dsanders11! Updated the PR title and description

@jkleinsc jkleinsc merged commit 29d7be1 into electron:main Oct 31, 2023
15 checks passed
@welcome Welcome
Copy link

welcome bot commented Oct 31, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk Release Clerk
Copy link

release-clerk bot commented Oct 31, 2023

No Release Notes

@devm33 devm33 deleted the devm33/utility_namespace branch October 31, 2023 20:38
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@devm33 @dsanders11
build: update @electron/docs-parser and @electron/typescript-definiti…
7fc1af3 
…ons (electron#40264)

* feat: add utility process typescript namespace

Upgrades docs-parser and typescript-definitions to add new
'electron/utility' namespace added in:
- electron/docs-parser#95
- electron/typescript-definitions#246
- electron/typescript-definitions#247

* build: update yarn.lock

---------

Co-authored-by: David Sanders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devm33 @dsanders11 @jkleinsc