-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent checking isDesktopCapturerEnabled, which crashes on electron@26 #154
Conversation
Not sure of the side effects of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want to check isDesktopCapturerEnabled
on versions of Electron that still have that method.
E.g. features.isDesktopCapturerEnabled?.()
I think will do that 👍
In E26 the desktop capturer is always enabled, so it has to be |
Of course. Should we do it like
To keep the style consistent? |
🎉 This PR is included in version 2.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Looks like this wasn't quite the right fix for this issue - it still errors when the function isn't defined. When
|
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
No description provided.