Add a utility function to execute hooks serially #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
test/hooks.js
Outdated
| } | ||
| const testHooks = [ | ||
| () => { output += ' 1'; return Promise.resolve() }, | ||
| timeoutFunc(2), |
There was a problem hiding this comment.
Can we use this in the above test as well
test/hooks.js
Outdated
|
|
||
| test('serialHooks executes functions serially', t => { | ||
| let output = '0' | ||
| const timeoutFunc = number => { |
There was a problem hiding this comment.
If this helper takes in the timeout as well we can remove more code duplication below for the hooks that instantly resolve
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 12 +1
Lines 597 607 +10
=====================================
+ Hits 597 607 +10
Continue to review full report at Codecov.
|
|
This is great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Adds
serialHooks(hooks)(ported from Electron Forge), which allows a user to run hooks serially instead of in parallel (which was added in v10.0.0 due toPromise.all).Closes #812.