Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include asar integrity when using --prebuilt-asar #1763

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

slashnick
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

If you are building an app with a prebuilt ASAR archive, we should still include the ASAR integrity hash in the app bundle.

@slashnick slashnick requested a review from a team as a code owner August 13, 2024 21:50
Copy link

welcome bot commented Aug 13, 2024

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (426b886) to head (6b03d21).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1763      +/-   ##
==========================================
- Coverage   89.28%   89.08%   -0.20%     
==========================================
  Files          17       17              
  Lines         905      907       +2     
  Branches      187      187              
==========================================
  Hits          808      808              
- Misses         61       62       +1     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarshallOfSound MarshallOfSound merged commit 18b0c69 into electron:main Aug 13, 2024
4 of 5 checks passed
Copy link

welcome bot commented Aug 13, 2024

Thanks for your contribution! 🎉

@dsanders11 dsanders11 mentioned this pull request Aug 20, 2024
2 tasks
Copy link

🎉 This PR is included in version 18.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants