-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: appDireactory missing for windows-sign options #1731
Conversation
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 17 17
Lines 905 905
Branches 187 187
=======================================
Hits 806 806
Misses 62 62
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch!
The test failure is unrelated and exists on main, merging. |
Thanks for your contribution! 🎉 |
🎉 This PR is included in version 18.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summarize your changes:
Fixing windows-sign does not work due to
appDirectory
missing.