feat!: upgrade Node.js to 14 LTS #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
force-pushed
the
bump-node-14-lts
branch
from
398621c
to
50de9f2
Compare
VerteDinde
force-pushed
the
bump-node-14-lts
branch
from
50de9f2
to
dc12942
Compare
Codecov Report
@@ Coverage Diff @@
## main #1393 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 15 15
Lines 776 776
=======================================
Hits 742 742
Misses 34 34 Help us with your feedback. Take ten seconds to tell us how you rate us. |
erickzhao
approved these changes
Aug 2, 2022
|
Thanks for your contribution! 🎉 |
|
@erickzhao probably want to revert this first, merge #1391, release a new version, then merge this and make a new release... otherwise folks using Electron 20 will need to upgrade to a new major version of Electron Packager. |
5 tasks
mtahiryilmazz
referenced
this pull request
in mtahiryilmazz/electron-packager
Sep 23, 2022
* Revert "feat!: upgrade Node.js to 14 LTS (#1393)" This reverts commit c6b4c78. * build: yargs to 20.2.9, xcode 12.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Electron Packager is still using Node 10 and Node 12; Node 12 was deprecated in April 2022. This PR requires at least Node 14 LTS, and bumps the automated tests to test on newer versions of Node (14, 16, 18 as opposed to 10, 12, 14).
NB: Since this would be a breaking change, we may want to merge other fixes first and do another release before merging this one.