Allow skipping Gatekeper check #100
Conversation
There was a problem hiding this comment.
Hi @salomvary thanks for opening this PR! I've been busy lately while not addressing the issues here. Here are a few suggestions from me for this PR before having it merged:
- The
minimistmodule we used inelectron-osx-signshould convert--no-gatekeeper-checkto--gatekeeper-checktofalse. gatekeeper's spelled asgetekeeperin the source code.
Would you mind reviewing the two?
| @@ -150,6 +150,11 @@ Default to system default keychain. | |||
| Regex or function that signals ignoring a file before signing. | |||
| Default to `undefined`. | |||
|
|
|||
| `no-getekeeper-check` - *Boolean* | |||
There was a problem hiding this comment.
I would recommend naming it gatekeeper-assess where false disables Gatekeeper check.
| @@ -35,6 +35,9 @@ DESCRIPTION | |||
| The keychain name. | |||
| Default to system default keychain. | |||
|
|
|||
| --no-getekeeper-check | |||
There was a problem hiding this comment.
Like --pre-auto-entitlements, --no-pre-auto-entitlements, --gatekeeper-assess, --no-gatekeeper-assess may then enable/disable the feature.
|
Thanks for the feedback @sethlu, I addressed your suggestions. |
| @@ -103,7 +103,7 @@ function verifySignApplicationAsync (opts) { | |||
| }) | |||
|
|
|||
| // Additionally test Gatekeeper acceptance for darwin platform | |||
| if (opts.platform === 'darwin') { | |||
| if (opts.platform === 'darwin' && opts['gatekeeper-assess']) { | |||
There was a problem hiding this comment.
I'm not sure if it would be better to have && opts['gatekeeper-assess'] as && opts['gatekeeper-assess'] !== false so it is still by default enabled for users not using the command line.
There was a problem hiding this comment.
Definitely should. Otherwise programmatic default is not equals to CLI and it is strange.
|
Thanks @salomvary! There are a few more suggestions I have; but after that, I believe the PR's ready to merge. |
| @@ -103,7 +103,7 @@ function verifySignApplicationAsync (opts) { | |||
| }) | |||
|
|
|||
| // Additionally test Gatekeeper acceptance for darwin platform | |||
| if (opts.platform === 'darwin') { | |||
| if (opts.platform === 'darwin' && opts['gatekeeper-assess']) { | |||
There was a problem hiding this comment.
Definitely should. Otherwise programmatic default is not equals to CLI and it is strange.
Issue related to: electron#100
Fixes #83. Wdyt?