Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-base): use minimum instead of exact version when replacing ELECTRON_FORGE/VERSION in templates #3030

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

erikian
Copy link
Member

@erikian erikian commented Oct 31, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
This PR ensures that the most recent compatible version of @electron-forge/plugin-webpack will be installed by create-electron-app. While the package.json might still show an older version when using create-electron-app (as outlined in #3019 (comment)), the version yarn / npm will actually install is the most recent.

@erikian erikian changed the title fix(template-base): use minimum instead of exact version when replaci… fix(template-base): use minimum instead of exact version when replacing ELECTRON_FORGE/VERSION in templates Oct 31, 2022
@erikian erikian mentioned this pull request Oct 31, 2022
3 tasks
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with siblingDep in init-npm 👍

@MarshallOfSound MarshallOfSound merged commit 7aaa702 into electron:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants