Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum Node version to 10 #1405

Merged
merged 7 commits into from
Jan 16, 2020
Merged

chore: bump minimum Node version to 10 #1405

merged 7 commits into from
Jan 16, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jan 15, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a script that bumps Node versions in all packages, and updates several packages that require Node 10.

BREAKING CHANGE: Dropped declared support for Node < 10

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1405 into master will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
- Coverage      72%   70.24%   -1.76%     
==========================================
  Files          73       73              
  Lines        2104     2104              
  Branches      389      389              
==========================================
- Hits         1515     1478      -37     
- Misses        427      478      +51     
+ Partials      162      148      -14
Impacted Files Coverage Δ
packages/maker/squirrel/src/MakerSquirrel.ts 30% <0%> (-45%) ⬇️
packages/maker/wix/src/MakerWix.ts 40% <0%> (-45%) ⬇️
packages/maker/appx/src/MakerAppX.ts 19.64% <0%> (-35.72%) ⬇️
packages/maker/wix/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/appx/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/flatpak/src/MakerFlatpak.ts 78.26% <0%> (-8.7%) ⬇️
packages/maker/base/src/Maker.ts 70.27% <0%> (-2.71%) ⬇️
packages/api/core/src/api/import.ts 58.82% <0%> (ø) ⬆️
packages/maker/dmg/src/MakerDMG.ts 100% <0%> (+5.55%) ⬆️
packages/api/core/src/api/make.ts 70.78% <0%> (+5.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf28ca...3169b92. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant