-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Windows zip builds are always broken #670
Comments
Due to electron/forge#670, they are broken (see httptoolkit/httptoolkit#16)
This should be fixed in Forge 6.x, where I don't have any plans for fixing this in the 5.x series, because I don't have the capability to test extensively for regressions when switching zip implementations on all platforms. |
Fair enough, I'm happy to roll forward if I can. Is v6 stable, or does it have a schedule for it will be? Are there docs anywhere I can use on how to upgrade? |
There is no schedule, but there is a tracking issue: #621 I need to make a new release with the simple 5.x importer and then write some docs on how to upgrade when you're using an external config file. |
Great, thanks, I'll keep an eye on those. |
Please describe your issue:
When building the
zip
make target for Windows, the resulting build is never usable. Squirrel installers still seem to work fine.See full project here for an example: https://github.com/httptoolkit/httptoolkit-desktop.
This happens because:
.
by default..cache
folder for electron-compile is not included in the zip..cache
does not exist, electron-compile does not run in production mode.electron-compilers
, which generally doesn't exist (and shouldn't be used in production builds regardless), so the whole app crashes immediately.The text was updated successfully, but these errors were encountered: