refactor(publisher-gcs): extracted ternary operator

electron · Jun 10, 2020 · ba0a77f · ba0a77f
1 parent 072085e
commit ba0a77f
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/packages/publisher/gcs/src/PublisherGCS.ts b/packages/publisher/gcs/src/PublisherGCS.ts
@@ -37,12 +37,17 @@ export default class PublisherGCS extends PublisherBase<PublisherGCSConfig> {
     const clientEmail = config.clientEmail || process.env.GOOGLE_CLOUD_CLIENT_EMAIL;
     const privateKey = config.privateKey || process.env.GOOGLE_CLOUD_PRIVATE_KEY;
 
-    const storage = new Storage({
-      keyFilename: config.projectId || process.env.GOOGLE_APPLICATION_CREDENTIALS,
-      credentials: (clientEmail && privateKey) ? {
+    let credentials;
+    if (clientEmail && privateKey) {
+      credentials = {
         client_email: clientEmail,
         private_key: privateKey,
-      } : undefined,
+      };
+    }
+
+    const storage = new Storage({
+      keyFilename: config.projectId || process.env.GOOGLE_APPLICATION_CREDENTIALS,
+      credentials,
       projectId: config.projectId || process.env.GOOGLE_CLOUD_PROJECT,
     });