test(plugin-fuses): clear test TODOs (#3306)

electron · Aug 20, 2023 · 7d5e748 · 7d5e748
1 parent 3d2e8d4
commit 7d5e748
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/packages/plugin/fuses/test/FusesPlugin_spec_slow.ts b/packages/plugin/fuses/test/FusesPlugin_spec_slow.ts
@@ -23,10 +23,7 @@ describe('FusesPlugin', () => {
 
   const { name: appName } = packageJSON;
 
-  // @TODO get rid of this once https://github.com/electron/forge/pull/3123 lands
-  const platformArchSuffix = `${process.platform}-x64`;
-
-  const outDir = path.join(appPath, 'out', `${appName}-${platformArchSuffix}`);
+  const outDir = path.join(appPath, 'out', 'fuses-test-app');
 
   before(async () => {
     delete process.env.TS_NODE_PROJECT;
@@ -36,9 +33,6 @@ describe('FusesPlugin', () => {
 
   after(async () => {
     await fsExtra.remove(path.resolve(outDir, '../'));
-
-    // @TODO this can be removed once the mock app installs a published version of @electron-forge/plugin-fuses instead of a local package
-    await fsExtra.remove(path.join(__dirname, './fixture/app/node_modules'));
   });
 
   it('should flip Fuses', async () => {
@@ -51,6 +45,7 @@ describe('FusesPlugin', () => {
     });
 
     const args: string[] = process.platform === 'linux' ? ['-v', '--no-sandbox'] : ['-v'];
+
     /**
      * If the `RunAsNode` fuse had not been flipped,
      * this would return the Node.js version (e.g. `v14.16.0`)

diff --git a/packages/plugin/fuses/test/fixture/app/package.json.tmpl b/packages/plugin/fuses/test/fixture/app/package.json.tmpl
@@ -10,9 +10,9 @@
     "fs-extra": "^10.0.0"
   },
   "devDependencies": {
-    "@electron-forge/cli": "6.0.5",
-    "@electron-forge/plugin-fuses": "file:./../../../../fuses",
-    "@electron-forge/shared-types": "6.0.5",
+    "@electron-forge/cli": "6.4.0",
+    "@electron-forge/plugin-fuses": "6.4.0",
+    "@electron-forge/shared-types": "6.4.0",
     "electron": "12.0.0"
   }
 }