Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: load macOS release secrets from secret service #1465

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

dsanders11
Copy link
Member

Shifting more usage to the secret service.

@dsanders11 dsanders11 requested review from codebytere and a team as code owners September 22, 2023 21:09
@coveralls
Copy link

Coverage Status

coverage: 87.059%. remained the same when pulling eb582f9 on ci-load-macos-secrets into 815d777 on main.

@@ -175,6 +176,7 @@ workflows:
parameters:
arch: [ x64 ]
- mac-build:
context: fiddle-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll eventually need this context in all build steps but approving since Mac is ready now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, once we move the remaining secrets. I'm contemplating making a context per-platform just to silo them a bit more and only providing them on more of a "need to know" basis.

@dsanders11 dsanders11 merged commit cb8bd5d into main Sep 22, 2023
3 checks passed
@dsanders11 dsanders11 deleted the ci-load-macos-secrets branch September 22, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants