Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting gist files #1458

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: deleting gist files #1458

merged 1 commit into from
Sep 11, 2023

Conversation

codebytere
Copy link
Member

Closes #1457.

The previous logic appears to have been based on a misconception:

Gist files are deleted by setting content to an empty string.

Per docs:

To delete a file, set the whole file to null. For example: hello.py : null. The file will also be deleted if the specified object does not contain at least one of content or filename.

@coveralls
Copy link

Coverage Status

coverage: 88.325% (+1.2%) from 87.085% when pulling de22364 on fix-deleting-gist-files into d7c49b6 on main.

@dsanders11 dsanders11 merged commit 57b50d4 into main Sep 11, 2023
3 checks passed
@dsanders11 dsanders11 deleted the fix-deleting-gist-files branch September 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gist files aren't deleted properly.
3 participants