fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() #44238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
ckerr
force-pushed
the
fix/Wunsafe-buffer-usage-warnings-in-TaskbarHost
branch
from
708d6f9
to
c5e673b
Compare
codebytere
approved these changes
Oct 15, 2024
github-actions
bot
added
the
target/34-x-y
|
No Release Notes |
|
I was unable to backport this PR to "32-x-y" cleanly; |
|
I was unable to backport this PR to "31-x-y" cleanly; |
trop
bot
added
needs-manual-bp/32-x-y
needs-manual-bp/31-x-y
and removed
target/32-x-y
This was referenced Oct 15, 2024
|
I have automatically backported this PR to "34-x-y", please check out #44259 |
trop
bot
added
in-flight/34-x-y
and removed
target/34-x-y
|
I have automatically backported this PR to "33-x-y", please check out #44260 |
trop
bot
added
merged/34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…() (electron#44238) * fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() * fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (electron#44211)
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…() (electron#44238) * fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() * fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (electron#44211)
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…() (electron#44238) * fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() * fixup! fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (electron#44211)
trop
bot
added
merged/31-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Part 19 in a series to fix
-Wunsafe-buffer-usagewarnings inshell/. This PR fixes warnings in an array loop inTaskbarHost::SetThumbarButtons()by addingconstexprandstd::arrayso that the compiler has enough info to know that the array index is always valid.Checklist
npm testpassesRelease Notes
Notes: none.