Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delay emitting powerMonitor events on windows #26180

Merged
merged 6 commits into from
Oct 28, 2020
Merged

fix: delay emitting powerMonitor events on windows #26180

merged 6 commits into from
Oct 28, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 27, 2020

Backport of #25836

See that PR for details.

Notes: Fixed a rare crash on Windows that could occur when emitting certain powerMonitor events.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 27, 2020
@trop trop bot requested a review from nornagon October 27, 2020 01:25
@trop trop bot mentioned this pull request Oct 27, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 27, 2020
@ckerr
Copy link
Member

ckerr commented Oct 28, 2020

webContents module printToPDF() can print to PDF

failure is unrelated.

@ckerr ckerr merged commit ccbf615 into 10-x-y Oct 28, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 28, 2020

Release Notes Persisted

Fixed a rare crash on Windows that could occur when emitting certain powerMonitor events.

@ckerr ckerr deleted the trop/10-x-y-bp-fix-delay-emitting-powermonitor-events-on-windows-1603761939686 branch October 28, 2020 17:38
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @codebytere @nornagon