Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Chrome 70 #15059

Closed
iclems opened this issue Oct 10, 2018 · 10 comments
Closed

Update to Chrome 70 #15059

iclems opened this issue Oct 10, 2018 · 10 comments

Comments

@iclems
Copy link

iclems commented Oct 10, 2018

Is your feature request related to a problem? Please describe.
Chrome 70 provides significant WebRTC fixes and improvements.

Describe the solution you'd like
Specifically, enables navigator.getDisplayMedia

Describe alternatives you've considered
desktopCapture allows to build a custom integration, but getDisplayMedia is becoming a standard

@welcome
Copy link

welcome bot commented Oct 10, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@MarshallOfSound
Copy link
Member

@iclems Hey, we have recently landed the chromium 69 upgrade into master, however, Chromium 70 is not stable yet and our next major release (4.0.0) is being cut imminently, 70 won't a part of that release.

I see you commenting on #1380 about this feature, at the moment we have no timeline on a C70 upgrade so I'd suggest you stay with that comment thread regarding navigator.getDisplayMedia.

Going to close this out, when we get to the C70 upgrade a tracking PR will be raised and you can follow along there.

@iclems
Copy link
Author

iclems commented Oct 10, 2018

Thank you @MarshallOfSound - Makes sense. Sad, 70 is going stable in the next 6 days. Great work on 4.0.0 and thanks for the quick feedback!

@iclems
Copy link
Author

iclems commented Nov 7, 2018

@MarshallOfSound is is worth it re-opening this in the future?

@MarshallOfSound
Copy link
Member

@iclems We are focusing on stabilizing 4.0 but the C70 upgrade is in PR atm.

@iclems
Copy link
Author

iclems commented Dec 13, 2018

@MarshallOfSound awesome - i saw this got merged but strangly enough with 4.0.0-beta.9 I'm still getting Chromium 68 apparently. When would 70 make it into the nightly? Thank you and apologies if I missed something here!

@iclems
Copy link
Author

iclems commented Dec 13, 2018

Just realized beta.9 was apparently cut 2 days before the merge. So I guess I need to wait for beta.10?

@nornagon
Copy link
Member

We don't upgrade chrome major version after the first beta is cut. Electron 4.0.0 will be released with Chromium 69.0.3497.106.

@iclems
Copy link
Author

iclems commented Dec 13, 2018 via email

@nornagon
Copy link
Member

No, we only upgrade major chrome versions with major electron versions. The next version to include an upgrade of Chromium will be Electron 5. See https://electronjs.org/docs/tutorial/electron-versioning#semver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants