Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types of wrapped Electron methods to return Promise #999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jul 8, 2021

Fixes #878, fixes #998.

@andersk andersk force-pushed the promise-types branch 2 times, most recently from d54b176 to fb20c86 Compare July 8, 2021 22:41
@andersk andersk mentioned this pull request Jul 8, 2021
@VerteDinde
Copy link
Collaborator

@andersk Sorry it took so long for someone to see this 🙂 I merged your doc/type PR and I think I can reconcile the conflicts in the main definition file, but let me know if that seems reasonable and we can merge this one as well!

@andersk
Copy link
Contributor Author

andersk commented Sep 16, 2021

The PR you merged (#897) is not mine. Like I said there, this is a more complete fix. It was was intended to be merged instead of #897, not in addition to #897.

However, I’ve now resolved the conflicts so this can be applied on top.

@jlennox
Copy link

jlennox commented Jan 11, 2022

@andersk @VerteDinde Is there any update on this?

This would presumably fix an issue I am seeing:

.../node_modules/spectron/lib/spectron.d.ts:260:24 - error TS2694: Namespace 'Electron.CrossProcessExports' has no exported member 'RemoteMainInterface'.

260     electron: Electron.RemoteMainInterface;
                           ~~~~~~~~~~~~~~~~~~~

‘declare module’ is for declaring a third-party module, not for
publishing first-party declarations.

Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants