Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update snapcraft requirements, fix ci multipass errors #144

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

VerteDinde
Copy link
Collaborator

@VerteDinde VerteDinde commented Mar 31, 2022

This PR makes a number of improvements:

  • Moves strict confinement to being the default mode
  • Updates the template .yaml for strict confinement to include gnome extensions
  • Updates the base template to distinguish between strict and classic confinement, and changes the needed stage files per confinement method
  • Adds tests for confinement and new interfaces
  • Modifies how our snaps are built in CI, so that CI testing actually works with multipass

Outside of this PR, I'd like to add the ability to add custom layouts (we already have to ability to add custom slots), but given the amount of changes in this PR alone, that work can be broken into a separate PR.

Note: This PR enables a user to build a snap locally by setting --provider:host as an argument. This is working in CI with multipass, but unfortunately does not yet work locally. I'm also working on fixing that in a separate PR.

Closes #113, sets the groundwork for closing #83

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

@VerteDinde VerteDinde changed the title fix: update snapcraft requirements, fix ci fix: update snapcraft requirements, fix ci multipass errors Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #144 (073aa83) into master (eb0998b) will increase coverage by 4.38%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #144      +/-   ##
===========================================
+ Coverage   95.61%   100.00%   +4.38%     
===========================================
  Files           8         8              
  Lines         251       259       +8     
===========================================
+ Hits          240       259      +19     
+ Misses         11         0      -11     
Impacted Files Coverage Δ
src/launcher.js 100.00% <100.00%> (ø)
src/snapcraft.js 100.00% <100.00%> (+23.33%) ⬆️
src/yaml.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (+5.35%) ⬆️
src/hooks.js 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0998b...073aa83. Read the comment docs.

@VerteDinde VerteDinde force-pushed the re-enable-ci-tests branch 4 times, most recently from 3eff834 to ce91597 Compare March 31, 2022 04:25
@VerteDinde VerteDinde marked this pull request as ready for review March 31, 2022 04:35
@VerteDinde VerteDinde requested a review from malept March 31, 2022 04:39
@VerteDinde VerteDinde merged commit 0549fd8 into master Apr 17, 2022
@VerteDinde VerteDinde deleted the re-enable-ci-tests branch April 17, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"classic" confinement needs but doesn't install bin/electron-launch
1 participant