Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update tests #142

Merged
merged 1 commit into from
Feb 8, 2022
Merged

build: update tests #142

merged 1 commit into from
Feb 8, 2022

Conversation

VerteDinde
Copy link
Collaborator

@VerteDinde VerteDinde commented Feb 8, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Some of the tests here are using older versions of Node and an outdated template for snapcraft.yml. This PR aims to upgrade the node versions and slightly modernize the .yaml so tests pass

NOTE: It looks like the serial tests have been failing consistently on CI, and are also failing locally. Master's last pass date is Dec. of 2020. These need to get back up and running, but is going to take either A) getting Multipass to work in GH Actions or B) a custom image that comes with the needed runners for snapcraft.

@VerteDinde VerteDinde force-pushed the update-tests branch 7 times, most recently from f2a5cbb to 56aaaa5 Compare February 8, 2022 18:39
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #142 (d822456) into master (7a4a4df) will decrease coverage by 4.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #142      +/-   ##
===========================================
- Coverage   100.00%   95.65%   -4.35%     
===========================================
  Files            8        8              
  Lines          253      253              
===========================================
- Hits           253      242      -11     
- Misses           0       11      +11     
Impacted Files Coverage Δ
src/snapcraft.js 76.66% <0.00%> (-23.34%) ⬇️
src/hooks.js 92.85% <0.00%> (-7.15%) ⬇️
src/index.js 94.64% <0.00%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4a4df...d822456. Read the comment docs.

@VerteDinde VerteDinde merged commit 49da95d into master Feb 8, 2022
@VerteDinde VerteDinde deleted the update-tests branch February 8, 2022 20:49
@welcome
Copy link

welcome bot commented Feb 8, 2022

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant