chore: allow disabling browser sandbox #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Resolves #74
This PR does not force the
browser-sandbox
interface totrue
. Having this sandbox requires a manual review in the Snap store, and is not used by many large Electron apps. In strict confinement mode, Electron apps can instead use the snap's confinement.We'll be moving the template from a default of classic to strict in the future, but this change will allow apps to build for the snap store and pass review without manual changes.