Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow disabling browser sandbox #141

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

VerteDinde
Copy link
Collaborator

@VerteDinde VerteDinde commented Feb 8, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Resolves #74

This PR does not force the browser-sandbox interface to true. Having this sandbox requires a manual review in the Snap store, and is not used by many large Electron apps. In strict confinement mode, Electron apps can instead use the snap's confinement.

We'll be moving the template from a default of classic to strict in the future, but this change will allow apps to build for the snap store and pass review without manual changes.

@welcome
Copy link

welcome bot commented Feb 8, 2022

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@VerteDinde VerteDinde force-pushed the disable-browser-sandbox branch 3 times, most recently from c3bbab8 to 3d0e0e4 Compare February 8, 2022 20:54
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #141 (53dd0be) into master (49da95d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 53dd0be differs from pull request most recent head 91afcf0. Consider uploading reports for the commit 91afcf0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   95.65%   95.61%   -0.04%     
==========================================
  Files           8        8              
  Lines         253      251       -2     
==========================================
- Hits          242      240       -2     
  Misses         11       11              
Impacted Files Coverage Δ
src/yaml.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49da95d...91afcf0. Read the comment docs.

@VerteDinde VerteDinde force-pushed the disable-browser-sandbox branch 2 times, most recently from 53dd0be to 91afcf0 Compare February 8, 2022 22:31
@VerteDinde VerteDinde force-pushed the disable-browser-sandbox branch from 91afcf0 to 36769bd Compare February 8, 2022 22:34
@VerteDinde VerteDinde merged commit eb0998b into master Feb 8, 2022
@VerteDinde VerteDinde deleted the disable-browser-sandbox branch February 8, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapcraft builds are always auto rejected
1 participant