-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the work. Having done a similar thing in -debian, I know how tedious that can get.
I took a cursory look - it's a large PR so I'm counting on the tests to help out 😄 I only saw a couple of cosmetic things that should change.
There's inconsistent use of ()
around a single arrow function parameter. Personally, I'd just get rid of the parentheses.
src/installer.js
Outdated
callback(new Error('Error reading package metadata: ' + (err.message || err))) | ||
} | ||
return fs.pathExists(withAsar) | ||
.then((assarExists) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asarExists
Also, I wonder if it'd be worth making some sort of |
@malept The majority of the code is just replicating the work you already did on Regarding the parenthesis, the "inconsistency" comes from me always using airbnb eslint rules which requires parenthesis if the function has a curly brackets body, otherwise no parenthesis. That's why it seems like there's inconsistency, but it follow that rule. Since we don't use that rule, I'll go ahead and remove all parentheses. Regarding the common module, it might not be a bad idea. The |
This PR does the following: