Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): add support for symbolic icons #70

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

fcastilloec
Copy link
Collaborator

See https://developer.gnome.org/ThemedIcons/ for more info on symbolic icons. We currently only support SVG for this type of icons, since it's the preferred one.

@fcastilloec fcastilloec requested a review from malept May 16, 2020 00:49
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          198       210   +12     
=========================================
+ Hits           198       210   +12     
Impacted Files Coverage Δ
src/installer.js 100.00% <100.00%> (ø)
src/dependencies.js 100.00% <0.00%> (ø)
src/readmetadata.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759c691...2e3eac4. Read the comment docs.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise :shipit:

src/installer.js Outdated Show resolved Hide resolved
@malept malept merged commit 0b689c2 into master May 19, 2020
@malept malept deleted the symbolic-icons branch May 19, 2020 20:07
@fcastilloec
Copy link
Collaborator Author

@malept When do you think it'll be a good idea to release v1.0.0? The code and API have become stable enough, and other modules are depending on this.
I have some other private modules and have been wondering when to release v1 until I found this

@malept
Copy link
Member

malept commented May 27, 2020

I think 1.0.0 will be released when everything in the TODOs (and follow ups) for #71 are done, plus removing the deprecated spawn export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants