Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(readMetadata): add support for macOS target apps #67

Merged
merged 2 commits into from
May 19, 2020

Conversation

malept
Copy link
Member

@malept malept commented Mar 13, 2020

This should make it easier for installer modules for macOS targets to utilize this module.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #67 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          198       206    +8     
=========================================
+ Hits           198       206    +8     
Impacted Files Coverage Δ
src/readmetadata.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22887d...04cca6f. Read the comment docs.

Copy link
Collaborator

@fcastilloec fcastilloec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, does this mean that electron-installer-dmg will be using this module? Or a new module is being developed for macOS based on -common?
Feel free to merge whenever you want

@malept
Copy link
Member Author

malept commented May 19, 2020

This is great, does this mean that electron-installer-dmg will be using this module? Or a new module is being developed for macOS based on -common?

This was written for use in Electron Forge. electron-installer-dmg doesn't need to look inside the app metadata.

@malept malept merged commit 85c2f7b into master May 19, 2020
@malept malept deleted the readmetadata-macos-app branch May 19, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants