Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): allow sourceDir to be used before options is set #46

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 13, 2019

Needed in the case where we introspect the source directory when generating defaults.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         198    204    +6     
=====================================
+ Hits          198    204    +6
Impacted Files Coverage Δ
src/installer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3cd9a...1aee158. Read the comment docs.

@malept malept merged commit 6352774 into master Dec 13, 2019
@malept malept deleted the early-source-dir branch December 13, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant