Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: let implementing modules specify revision fallbacks #29

Merged
merged 2 commits into from
May 24, 2019
Merged

fix: let implementing modules specify revision fallbacks #29

merged 2 commits into from
May 24, 2019

Conversation

malept
Copy link
Member

@malept malept commented May 24, 2019

Fixes #19.

@malept malept requested a review from fcastilloec May 24, 2019 17:02
@codecov
Copy link

codecov bot commented May 24, 2019 •
edited
Loading

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         196    196           
=====================================
  Hits          196    196
Impacted Files Coverage Δ
src/defaults.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9410835...ad67d6d. Read the comment docs.

@malept malept mentioned this pull request May 24, 2019
Closed
@malept malept force-pushed the configurable-fallback-revision branch from 57e1aaf to ad67d6d Compare May 24, 2019 19:46
fcastilloec
fcastilloec approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@fcastilloec fcastilloec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this solution. Also, related to Travis, maybe we should prevent merging PRs if they failed Travis testing, now that we have a fix for it.

@fcastilloec fcastilloec merged commit 0107a18 into master May 24, 2019
@fcastilloec fcastilloec deleted the configurable-fallback-revision branch May 24, 2019 19:58
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcastilloec fcastilloec fcastilloec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revision use
2 participants
@malept @fcastilloec