Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node 8 syntax support #27

Merged
merged 10 commits into from
May 23, 2019
Merged

feat: add Node 8 syntax support #27

merged 10 commits into from
May 23, 2019

Conversation

malept
Copy link
Member

@malept malept commented May 14, 2019

BREAKING CHANGE: Drops support for Node < 8.

  • Convert to async/await syntax
  • Adjust wrapError to be more async/await - friendly
  • Drop glob-promise in favor of util.promisify
  • Update dependencies which require Node >= 8

Closes #22.
Closes #24.
Closes #28.

@malept malept requested a review from fcastilloec May 14, 2019 15:10
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         190    196    +6     
=====================================
+ Hits          190    196    +6
Impacted Files Coverage Δ
src/spawn.js 100% <100%> (ø) ⬆️
src/readelectronversion.js 100% <100%> (ø) ⬆️
src/readmetadata.js 100% <100%> (ø) ⬆️
src/desktop.js 100% <100%> (ø) ⬆️
src/template.js 100% <100%> (ø) ⬆️
src/sandboxhelper.js 100% <100%> (ø) ⬆️
src/error.js 100% <100%> (ø) ⬆️
src/installer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57ca6e...c50f024. Read the comment docs.

@malept
Copy link
Member Author

malept commented May 23, 2019

Seems good. I updated most of the modules that depend on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant