chore: replace asar with @electron/asar
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could it be merged? |
mahnunchik
approved these changes
Sep 18, 2023
3 tasks
erikian
force-pushed
the
chore/electron-asar
branch
from
61daab9 to
d68dce3
Compare
|
cc @malept |
|
@fcastilloec @malept hi, still there? |
fcastilloec
approved these changes
Dec 11, 2023
|
Even though this has been merged, the final tools that depend on this might not get updated for a while. I can approve and merge PRs in this repo (I thought I couldn't), but not for the others ( |
|
I understand, the release is also needed ping @malept :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old
asarnpm package with@electron/asar, since all new versions from3.2.1onwards are being published to the latter.Users of
@electron-forge/maker-deb,@electron-forge/maker-rpm, and@electron-forge/maker-snapare currently stuck with[email protected], which was the latest published version of that package (and potentially have both packages installed, as Forge has already migrated to@electron/asarviaelectron-packager).