Skip to content

Commit

Permalink
chore: bump minimum Node version to 10 (#1405)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: removed declared support for Node < 10

* chore: add script to update the node version for all packages
* build(deps): upgrade semver to ^7.1.1
* build(deps-dev): upgrade commitizen to ^4.0.3
* build(deps): upgrade @malept/electron-installer-flatpak to ^0.11.0
* doc: update Node requirements in README
* build: use Node 10 for CI
  • Loading branch information
malept authored Jan 16, 2020
1 parent 9bf28ca commit 0190538
Show file tree
Hide file tree
Showing 47 changed files with 272 additions and 136 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ jobs:
run: |
sudo add-apt-repository -y ppa:alexlarsson/flatpak
sudo apt-get update
sudo apt-get install -y --no-install-recommends snapcraft flatpak-builder
sudo apt-get install -y --no-install-recommends snapcraft flatpak-builder elfutils
ci/install_runtimes.sh
- name: Use Node.js 8.x
- name: Use Node.js 10.x
uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 10.x
- name: Determine Yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ are looking for the 5.x series (the version currently published to NPM under `el

# Getting Started

**Note**: Electron Forge requires Node 8 or above, plus git installed.
**Note**: Electron Forge requires Node 10 or above, plus git installed.

If you have a more recent version of `npm` or `yarn`, you can use
[`npx`](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b),
Expand Down
4 changes: 2 additions & 2 deletions ci/install_runtimes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ install_flatpak() {

flatpak remote-add --user --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo

install_runtime x86_64 org.freedesktop.Sdk 1.6
install_runtime x86_64 org.freedesktop.Platform 1.6
install_runtime x86_64 org.freedesktop.Sdk 19.08
install_runtime x86_64 org.freedesktop.Platform 19.08
install_app x86_64 org.electronjs.Electron2.BaseApp stable

mkdir -p fakesnap/snap
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"parse-author": "^2.0.0",
"pretty-ms": "^5.0.0",
"resolve-package": "^1.0.1",
"semver": "^6.3.0",
"semver": "^7.1.1",
"source-map-support": "^0.5.13",
"sudo-prompt": "^9.1.1",
"username": "^5.1.0",
Expand Down Expand Up @@ -138,7 +138,7 @@
"chai": "4.2.0",
"chai-as-promised": "^7.0.0",
"codecov": "^3.6.1",
"commitizen": "^3.1.1",
"commitizen": "^4.0.3",
"cross-env": "^6.0.3",
"cz-customizable": "^6.2.0",
"eslint": "^6.8.0",
Expand All @@ -160,7 +160,7 @@
"typescript": "^3.7.3"
},
"optionalDependencies": {
"@malept/electron-installer-flatpak": "^0.10.0",
"@malept/electron-installer-flatpak": "^0.11.0",
"electron-installer-debian": "^2.0.0",
"electron-installer-dmg": "^3.0.0",
"electron-installer-redhat": "^2.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/api/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"debug": "^4.1.0",
"fs-extra": "^8.1.0",
"inquirer": "^7.0.1",
"semver": "^6.3.0"
"semver": "^7.1.1"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
}
}
4 changes: 2 additions & 2 deletions packages/api/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@
"node-fetch": "^2.6.0",
"nugget": "^2.0.1",
"resolve-package": "^1.0.1",
"semver": "^6.3.0",
"semver": "^7.1.1",
"source-map-support": "^0.5.13",
"sudo-prompt": "^9.1.1",
"username": "^5.1.0",
"yarn-or-npm": "^3.0.1"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/installer/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/darwin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/deb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-linux": "6.0.0-beta.47"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/dmg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-darwin": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/exe/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/linux/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/rpm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-linux": "6.0.0-beta.47"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/zip/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/installer-darwin": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/appx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/shared-types": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/deb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/dmg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
4 changes: 2 additions & 2 deletions packages/maker/flatpak/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
"@electron-forge/shared-types": "6.0.0-beta.47",
"fs-extra": "^8.1.0"
},
"optionalDependencies": {
"@malept/electron-installer-flatpak": "^0.10.0"
"@malept/electron-installer-flatpak": "^0.11.0"
}
}
2 changes: 1 addition & 1 deletion packages/maker/pkg/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/rpm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/snap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/squirrel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/wix/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/zip/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/auto-unpack-natives/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"main": "dist/AutoUnpackNativesPlugin.js",
"typings": "dist/AutoUnpackNativesPlugin.d.ts",
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/plugin-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/shared-types": "6.0.0-beta.47"
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/compile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/local-electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/plugin-base": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/publisher/bitbucket/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/electron-release-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/github/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"sinon": "^8.0.4"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/nucleus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/s3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/snapcraft/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.2.2"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/template/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"test": "echo No Tests"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
2 changes: 1 addition & 1 deletion packages/template/typescript-webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"test": "echo No Tests"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.47",
Expand Down
Loading

0 comments on commit 0190538

Please sign in to comment.