This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Added EJS compiler #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for
.ejsfiles toelectron-compilers.Used the GraphQL PR as a reference for what files to change.
Used the JadeCompiler as a starting template for this compiler, as their syntax for loading files looked very similar. However, I was not familiar with the
sourceMapusage, so I removed it, however it can be added back in if needed.Since ejs allows you to pass in data, and those familiar with other ejs electron packages are used to being able to provide data and options, I added this to the compiler. I'm not quite sure the best way to make it possible however. One way seemed to access
globalCompilerHost.compilersByMimeType.ejs.data, but I would appreciate any feedback or thoughts on this.I'm also not sure how it will handle caching, as ejs files are able to
include()other ejs files.