This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Add paths from 'includePaths' to Sass compiler #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen and encountered some issues regarding imports in Sass files. The proposed changes fixed the issues for me.
I use the property
includePaths
in.compilerc
which is read bysass.js
. The propertyincludePaths
is added tothis.compilerOptions
but is not a valid option for the compiler. So, after reading the property and adding the paths to be included topaths
, I discard it before is gets passed to sass.compiler.I've tested the changes in a standard project created by
electron-forge init
and added a few stylesheets containing imports (e.g. bootstap scss files).The includePaths is added to
.compilerc
like:The includePaths are relative to the stylesheet being compiled.