Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Pass filePath to compiler.shouldCompileFile() instead of code #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alreece45
Copy link

@alreece45 alreece45 commented Aug 15, 2017

shouldCompileFile() is passed code, instead of filePath. The tests also suggest that the expected return value is filePath, rather than code. This commit corrects both to use filePath

Code loading is shifted so that it is only loaded when shouldCompileFile() returns true, rather than always.

@alreece45 alreece45 changed the title Pass filePath to compiler.shouldCompileFile() instaed of code Pass filePath to compiler.shouldCompileFile() instead of code Aug 15, 2017
@alreece45
Copy link
Author

It looks like there was an issue with nvm on the Travis build, can we request a re-run?

nvm --version
0.33.2
157.22s$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update      ; fi
error: RPC failed; curl 56 SSLRead() return error -36
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
Error: Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask failed!
Updated 2 taps (homebrew/core, homebrew/versions).

eliot-akira added a commit to eliot-akira/electron-compile that referenced this pull request Mar 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant