This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
Make file watching more robust #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `gaze` instead of `fs.watch()` for file watching. Fix an issue where `fs.watch()` does not detect file changes when using certain text editor features such as `backupcopy` in Vim. Fix an issue where multiple change events are received for the same change. Improve HMR speed by removing manual throttling on file changes in favor of the more robust debouncing performed by `gaze`.
|
@paulcbetts Any input for moving this forward? |
fasterthanlime
pushed a commit
to fasterthanlime/electron-compile
that referenced
this pull request
Aug 24, 2017
fasterthanlime
added a commit
to fasterthanlime/electron-compile
that referenced
this pull request
Aug 24, 2017
This reverts commit 7f00a68.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189, fixes #193
See #193 for more information
Use
gazeinstead offs.watch()for file watching.Fix an issue where
fs.watch()does not detect file changes when usingcertain text editor features such as
backupcopyin Vim.Fix an issue where multiple change events are received for the same
change.
Improve HMR speed by removing manual throttling on file changes in favor
of the more robust debouncing performed by
gaze.@paulcbetts mentioned experiencing issues on Windows in #190. It would be great to hear if this resolves those issues.