Add electron download options #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```javascript
function createDownloadOpts(opts: any, platform: string, arch: string, electronVersion: string) {
const downloadOpts = Object.assign({
cache: opts.cache,
strictSSL: opts["strict-ssl"]
}, opts.download)
```
the code has this option, but the doc does not declare it.
|
Thanks. In the future please edit |
develar
added a commit
to develar/electron-builder
that referenced
this pull request
Nov 19, 2016
gregnolle
pushed a commit
to voidbridge/electron-builder
that referenced
this pull request
Nov 28, 2016
* master: feat: electronDownload instead of download electron-userland#921 feat: rename LICENSE from electron dist to LICENSE.electron.txt fix: snap support, desktop integration attempt electron-userland#509 chore: update electron-macos-sign to 1.3.4 fix(mac): App rejected when Mac Developer certificate is in keychain electron-userland#890 feat(deb): Replace ia32 arch name with i386 in package filename feat(linux): lowercased linux executable WIP: snap support electron-userland#509 test: split to small files to make Jest happy feat(linux): Build snap packages for Linux electron-userland#509 test: migrate to Jest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code has this option, but the doc does not declare it.