Re-fetch downloads if cache directory has changed #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4955
Instead of busting the cache as I said in #4955, I use the environment variable content as a cache key prefix because it resolves the issue, there's less code to change, and if someone changes the environment variable back to a directory that was used before, it won't needlessly re-download items.
This promise catch wasn't the only issue. Some functions that called it were in lazy-val calls so they were caching the result. I removed the lazy-val usage making them a function that calls
getBin/getBinFromUrleach time (which itself uses the promise cache anyway so I think it's fine). Maybe some variables could be renamed now but I decided to change the minimum and see what you say.