Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appx): Invalid code signing tool when building for windows 10 arm64 #4879

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix(appx): Invalid code signing tool when building for windows 10 arm64 #4879

merged 1 commit into from
Apr 29, 2020

Conversation

shibayan
Copy link
Contributor

Fixes an error when generating appx for Windows 10 arm64 due to referencing a non-existent winCodeSign path. When building for arm64, the x64 version of winCodeSign is used.

Error log

  ⨯ Exit code: ENOENT. spawn C:\Users\shibayan\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0\windows-10\arm64\makeappx.exe ENOENT  stackTrace=
      Error: Exit code: ENOENT. spawn C:\Users\shibayan\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0\windows-10\arm64\makeappx.exe ENOENT
          at C:\Users\shibayan\Documents\electron-quick-start\node_modules\builder-util\src\util.ts:125:16
          at exithandler (child_process.js:310:5)
          at ChildProcess.errorhandler (child_process.js:322:5)
          at ChildProcess.emit (events.js:310:20)
          at Process.ChildProcess._handle.onexit (internal/child_process.js:273:12)
          at onErrorNT (internal/child_process.js:469:16)
          at processTicksAndRejections (internal/process/task_queues.js:84:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] dist: `electron-builder`
npm ERR! Exit status 1

@shibayan shibayan changed the title fix(appx): Invalid code signing tool path when building for windows 1… fix(appx): Invalid code signing tool when building for windows 10 arm64 Apr 15, 2020
@develar develar merged commit d898c4e into electron-userland:master Apr 29, 2020
@shibayan shibayan deleted the fix-appx-arm64 branch April 29, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants