Feature/do not ignore uninstall errors #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
julianhille
commented
Mar 26, 2019
julianhille
commented
- Uninstaller should be copied and not moved:
- Uninstaller return code should not be ignored
added 2 commits
March 26, 2019 10:28
The current installer does completely ignore if uninstalling failed this mostly will end up in installing fail. Checking if an uninstaller is present, its there on update, and expecting a return code of 0 would be sufficient.
The installer should not be moved outside of the directory as this kills consistency and makes clean up way harder if something with the uninstaller fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.