Allow --package-file arg to escape spaces in filenames #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now package file doesn't escape spaces in the filename, which causes a bug where the package file passed to the nsis installer to be incorrect. This means that when the installer runs, it will fail on folders such as `C:\Users\first last\appdata\roaming\package-version.7z` This fixes it by forcing the whole file path to be a single arg.
|
I doubt that it fixed mentioned issues — fix doesn't related to permissions. Anyway — thanks a lot, it may be a part of existing issues. |
|
It did fix the first one, because it was a misdiagnose on my end. I can look into fixing other ones with similar issues since I’ve gone through all the Nsis code and also through most of the update code |
|
@develar -> I was investigating this some more, and I noticed the permissions issue is related somehow to the oneClick setting. Haven't had lot of time to kind of dig through outside of the day job, but the fix above only worked on assistedInstaller, but not on oneClick. Will keep updates on this thread. |
|
Probably you are right — we pass args to elevate and so.. yeach. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now package file doesn't escape spaces in the filename, which causes a bug where the package file passed to the nsis installer to be incorrect. This means that when the installer runs, it will fail on folders such as
C:\Users\first last\appdata\roaming\package-version.7zThis issue only seems to occur upon a failed Differential update (due to perMachine) followed by a full download to the users' appdata folder.
This fixes it by forcing the whole file path to be a single arg. I believe this also fixes the following issue
#2640
I'm unsure if #2363 is the same issue, but I see similar symptoms