Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron-Builder leaves node process running after build is complete #928

Closed
ghost opened this issue Nov 21, 2016 · 1 comment
Closed

Electron-Builder leaves node process running after build is complete #928

ghost opened this issue Nov 21, 2016 · 1 comment
Labels
windows

Comments

@ghost
Copy link

ghost commented Nov 21, 2016 •
edited by ghost
Loading

  • Version: 8.6.0
  • Electron Version: 1.4.7
  • Target: Windows x64 NSIS

After the build command finishes there is still a node.exe process that stays running for up to a few minutes after the build command has finished. This is causing occasional problems on our CI server if two jobs are kicked off in quick succession on the same build agent as the 2nd job won't be able to clean up app directory as it's still in use by a process from the previous build.
@develar
Copy link
Member

develar commented Nov 29, 2016

Please try upcoming 10.2.0

develar added a commit that referenced this issue Nov 29, 2016
@develar
feat(nsis): use name instead of product name as inst dir
640fea0 
Do not use version in the inst dir path.

Close #926, #941, #810, #928
@develar develar closed this as completed Nov 29, 2016
@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@develar