NSIS electron-updater uninstalls old version, but does not install new version

[delewis13]

UPDATE - NAMING COLLISION BETWEEN INSTALLER & PRODUCT

I will note that there are a number of other threads / bugs that exhibit similar behaviour [i.e. uninstalls and doesn't reinstall], but all with seemingly different root causes. I have fixed this in my case, for my specific root cause [detailed below]. If this helps you, awesome - please post in the thread that it helped to let maintainers know.

If not, then your root cause is probably different - in this case, probably better you post on one of the other threads around this issue / create your own, rather than adding here.

THE FIX

Minimal reproduction: https://github.com/delewis13/electron-builder-minimal/tree/electron-updater-nsis-bug
Issue can be reproduced across multiple version combinations of electron-builder / electron / electron-updater

It seems there is some naming collision when the productName in your electron-builder config (which is used to name the installed .exe) and the artifactName (which is the installer) are the same (case-insensitive).

For example, previously I had productName: 'myapp' and artifactName: 'myApp.exe' which caused the issue as described below. Simply changing artifaceName: 'myApp Setup.exe resolved the issue.

ORIGINAL POST

electron: 11.1
electron-builder: 22.13.1
electron-updater: 4.3.9
node: 15.0.1

Pretty much as title says.

Tried with various build configs & electron-updater methods. The most simple of which was:

  },
  nsis: {
    oneClick: true,
    installerIcon: `./builder/images/ico/${pkg.productName}/recording.ico`,
    uninstallerIcon: `./builder/images/ico/${pkg.productName}/recording.ico`,
    installerHeaderIcon: `./builder/images/ico/${pkg.productName}/recording.ico`,
  },

with
autoUpdater.checkForUpdatesAndNotify()

Tested with & without code-signing cert

[Echo4F]

Install new version

[delewis13]

Install new version

New version of what? My electron-builder + electron-updater are both latest published on NPM :S

[Echo4F]

Uninstall old version

[Echo4F]

iOS is for iPhone and am using Android

…

On Thu, Oct 14, 2021, 1:04 PM Daniel ***@***.***> wrote: Install new version New version of what? My electron-builder + electron-updater are both latest published on NPM :S — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6329 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWA7QZ4AVNI2OFRRDGR4NZ3UG3BL3ANCNFSM5FYFC5KA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Echo4F]

I have done it
Please what next

[ragauskl]

This worked for me: #2363 (comment)

[delewis13]

Afraid none of those fixes helped @ragauskl :( Thanks for the suggestion though

[delewis13]

@mmaietta noticed you are quite active here - thought i'd tag you.

I've made a minimal reproduction of this error forked from electron-webpack-quick-start, though i've also reproduced it on other electron / electron builder versions.

See the initial post above for more info, i've updated it with link to minimal reproduction of bug + description

[robertpatrick]

@mmaietta I am seeing the same behavior with our app. autoInstallOnAppQuit=true works when the NSIS app is installed "only for you". When installed for "All users" and exiting the app, the Windows UAC prompt is displayed asking for permissions for the "old-installer". Upon granting permission, the app is uninstalled but the installer never starts (and no Windows UAC Prompt is ever displayed).

[ejwilburn]

We're seeing the same issue. This used to happen with just the advanced installer (not the one-click installer) and switching to the one-click installer fixed it for us but now auto-update is broken completely on Windows.

Windows 10 x64 in my test environment.

[delewis13]

@robertpatrick @ejwilburn

Looks like a similar symptom with a different root causes? I was observing the issue across all installer configs [regardless of one-click vs advanced, or all users vs single user].

You've probably already looked, but perhaps #2363?

[robertpatrick]

@delewis13 I didn't realize that #2363 existed. That, and #6425, have me concerned that this feature isn't being properly tested on Windows. What can I do to help get auto-update working correctly on Windows?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[robertpatrick]

@mmaietta i think this is resolved already, probably should close this.