Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude certain targets from Github release publishing #577

Closed
jwheare opened this issue Jul 11, 2016 · 5 comments · May be fixed by qcif/data-curator#563
Closed

Exclude certain targets from Github release publishing #577

jwheare opened this issue Jul 11, 2016 · 5 comments · May be fixed by qcif/data-curator#563

Comments

@jwheare
Copy link
Contributor

jwheare commented Jul 11, 2016

  • Version: 5.11.3
  • Target: windows, linux (deb+appimage), mac (dmg, zip, mas)

I'd like to be able to e.g. build for MAS on CI but not then publish to a Github release. Could you add a publish_filter build option to exclude certain targets?

I suppose a workaround for this right now would be to exclude MAS from the package.json default build options, and then run a separate build process with --target=mas --publish=never, but that would slow down the builds somewhat.

@develar
Copy link
Member

develar commented Jul 11, 2016

MAS will be excluded from publishing by default.

@jwheare
Copy link
Contributor Author

jwheare commented Jul 11, 2016

Thinking about this some more, what I actually want is for the MAS version to be published on CI so that I can download it for separate submission, but not published to Github.

Am I right in thinking this can be achieved by using Travis' built in support for uploading artifacts to S3? Does the electron-builder process support this parallel usage?

@develar
Copy link
Member

develar commented Jul 11, 2016

@jwheare Travis uploading is not good because of travis-ci/travis-ci#2577 If you want to publish MAS to s3 — it can be implemented.

@jwheare
Copy link
Contributor Author

jwheare commented Jul 11, 2016

@develar Looks like that issue is actually resolved in the comments (though not closed) and also it looks like you can customise the addons.artifacts.paths with custom commands.

I am not particularly attached to S3, and in fact it may be overcomplicating matters. I just want to be able to easily download it from somewhere. Maybe the Github release is after all the best place for it, since I am already downloading artifacts from there to perform final sanity testing. I just have to remember to remove it from the release before publishing it.

develar added a commit to develar/electron-builder that referenced this issue Sep 2, 2016
develar added a commit to develar/electron-builder that referenced this issue Sep 2, 2016
@develar develar closed this as completed in 138e8e2 Sep 2, 2016
@develar
Copy link
Member

develar commented Sep 2, 2016

Set build.mas.publish to null to disable publishing or set to bintray to publish to bintray ("to easily download it from somewhere."). Bintray — set package name to github repository name, bintray repository — standard generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants